Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 26, 2025

Summary

When creating a share the new password must be checked as the "old" password is always empty.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Sep 26, 2025
@susnux susnux marked this pull request as ready for review September 26, 2025 10:03
@susnux susnux requested a review from a team as a code owner September 26, 2025 10:03
@susnux susnux requested review from nfebe, sorbaugh and szaimen and removed request for a team September 26, 2025 10:03
@susnux susnux changed the title Fix/sharing password fix(sharing): ensure to check new password Sep 26, 2025
@susnux susnux requested review from CarlSchwan and removed request for sorbaugh September 26, 2025 10:03
@susnux
Copy link
Contributor Author

susnux commented Sep 26, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Sep 26, 2025

/backport to stable32

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
Copy link
Contributor Author

susnux commented Sep 26, 2025

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit 1f4117a into master Sep 26, 2025
138 of 140 checks passed
@susnux susnux deleted the fix/sharing-password branch September 26, 2025 14:58
@backportbot
Copy link

backportbot bot commented Sep 26, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55313/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 99a02621 7e424e3e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55313/stable32

Error: Failed to push branch backport/55313/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Sep 26, 2025

/backport to stable32

@backportbot
Copy link

backportbot bot commented Sep 26, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55313/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 99a02621 7e424e3e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55313/stable32

Error: Failed to push branch backport/55313/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Sep 26, 2025

/backport to stable32

@backportbot
Copy link

backportbot bot commented Sep 26, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55313/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 99a02621 7e424e3e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55313/stable32

Error: Failed to push branch backport/55313/stable32: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Sep 26, 2025

/backport 99a0262 to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants