Skip to content

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 26, 2025

Summary

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 32 milestone Sep 26, 2025
@CarlSchwan CarlSchwan self-assigned this Sep 26, 2025
@CarlSchwan CarlSchwan requested a review from a team as a code owner September 26, 2025 15:18
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 26, 2025
@CarlSchwan CarlSchwan requested review from nfebe, sorbaugh and susnux and removed request for a team September 26, 2025 15:18
@github-actions github-actions bot changed the title feat: Mark OC.SystemTags as deprecated [stable32] feat: Mark OC.SystemTags as deprecated Sep 26, 2025
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be against master then backported? Needs to be in master too in any case.

P.S. Needs docs: https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_32.html

@joshtrichards
Copy link
Member

Never mind... I see #55320 now.

@joshtrichards
Copy link
Member

/compile

@joshtrichards joshtrichards added the pending documentation This pull request needs an associated documentation update label Sep 26, 2025
Signed-off-by: nextcloud-command <[email protected]>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private anyways 🤷

@nickvergessen
Copy link
Member

Private anyways 🤷

No, all old JS is to be considered used api. These functions and objects are older than the existance of our libraries and public JS definition. It's like OC_App basically. Defacto public, should be deprecated and documented properly and as long as possible

@susnux susnux merged commit 5d7e3af into stable32 Sep 27, 2025
138 of 143 checks passed
@susnux susnux deleted the carl/oc-systemtags-deprecated branch September 27, 2025 12:23
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@blizzz blizzz mentioned this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants