Skip to content

[stable31] fix(appstore): Also catch ClientException and ServerException #55436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Sep 30, 2025
Merged

[stable31] fix(appstore): Also catch ClientException and ServerException #55436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(appstore): Also catch ClientException and ServerException 
Signed-off-by: Marcel Müller <[email protected]>
  • Loading branch information
@SystemKeeper @backportbot
SystemKeeper authored and backportbot[bot] committed Sep 30, 2025
commit ddd35e155cf58b65de724ed2d6d4c94db21cfb09
4 changes: 3 additions & 1 deletion lib/private/App/AppStore/Fetcher/Fetcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
*/
namespace OC\App\AppStore\Fetcher;

use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Exception\ConnectException;
use GuzzleHttp\Exception\ServerException;
use OC\Files\AppData\Factory;
use OCP\AppFramework\Http;
use OCP\AppFramework\Utility\ITimeFactory;
Expand Down Expand Up @@ -87,7 +89,7 @@ protected function fetch($ETag, $content) {
$client = $this->clientService->newClient();
try {
$response = $client->get($this->getEndpoint(), $options);
} catch (ConnectException $e) {
} catch (ConnectException|ClientException|ServerException $e) {
$this->config->setAppValue('settings', 'appstore-fetcher-lastFailure', (string)time());
$this->logger->error('Failed to connect to the app store', ['exception' => $e]);
return [];
Expand Down
Loading