Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Oct 1, 2025

  • Resolves: none

Summary

The documentation of the method says it does not consider the user's language but it does. I adjusted the implementation because we already have the getLanguage() method which considers the user's language.

TODO

  • Fix tests
  • Fix CI

Checklist

@st3iny st3iny added this to the Nextcloud 33 milestone Oct 1, 2025
@st3iny st3iny self-assigned this Oct 1, 2025
@st3iny st3iny requested a review from a team as a code owner October 1, 2025 14:00
@st3iny st3iny added bug 3. to review Waiting for reviews labels Oct 1, 2025
@st3iny st3iny removed the request for review from a team October 1, 2025 14:00
@st3iny st3iny added the feature: language/translations (l10n/i18n) Localization and translation matters label Oct 1, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Oct 1, 2025
@st3iny st3iny marked this pull request as draft October 1, 2025 14:00
@st3iny st3iny added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 1, 2025
@st3iny
Copy link
Member Author

st3iny commented Oct 1, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Oct 1, 2025

/backport to stable32

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@SebastianKrupinski SebastianKrupinski force-pushed the fix/l10n/generic-language-no-user branch from b6a3a12 to ccc0c3c Compare November 11, 2025 00:50
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review November 11, 2025 01:11
@SebastianKrupinski
Copy link
Contributor

@ChristophWurst have another quick look at this one before I merge it

@SebastianKrupinski SebastianKrupinski merged commit fac380f into master Nov 25, 2025
195 of 197 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/l10n/generic-language-no-user branch November 25, 2025 15:42
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

5 participants