[stable29] refactor(ShareApiController): Add more error handling #55516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
changed the title
provokateurin
approved these changes
Oct 13, 2025
nfebe
force-pushed
the
backport/stable29/manaul/55151
branch
from
56f8d63 to
f0272f1
Compare
Contributor
Author
|
@sorbaugh please can you approve and force merge this backport. |
Member
|
@sorbaugh ping ^ |
…logging 1. Consolidated the repetitive provider code into a clean loop 2. Added exception handling to log unexpected errors Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
backport/stable29/manaul/55151
branch
from
f0272f1 to
03c4d74
Compare
nfebe
requested review from
artonge and
provokateurin
and removed request for
artonge and
provokateurin
artonge
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport : #55151