fix(LDAP): properly disable require TLS certificate verification (if configured) #55661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
CarlSchwan and
leftybournes
and removed request for
a team
- the old approach lead connection issues, as ldap_set_option was called too late. Specifically it needs to be called before ldap_connect and set globally! - The old approach also connected it to the ldapTLS configuration, which has a misleading naming. It indicates StartTLS usage only, not plain TLS connections. Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/55519/ldap-cert-req-handling
branch
from
35fe02b to
fbd29bc
Compare
blizzz
changed the title
Member
Author
|
relies on nextcloud/docker-ci#836 |
This was referenced Oct 9, 2025
Member
Author
|
/backport to stable32 |
come-nc
approved these changes
Oct 13, 2025
provokateurin
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)