Skip to content

[stable32] Fix comments when used by other apps #55663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 5 commits into from
Oct 10, 2025
Merged

[stable32] Fix comments when used by other apps #55663

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58ad14f
fix(comments): Use the correct object when autocompleting mentions fo…
nickvergessen Oct 9, 2025
5afc0bb
fix(comments): Correctly await the getComments() call
nickvergessen Oct 9, 2025
eabb387
fix(comments): Support user IDs that are numbers, e.g. "42"
nickvergessen Oct 9, 2025
fbc07ca
fix(comments): Don't throw type error when no itemType or itemId is g…
nickvergessen Oct 9, 2025
5519730
chore(assets): Recompile assets
nextcloud-command Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(comments): Use the correct object when autocompleting mentions fo… 
…r other apps

Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Oct 10, 2025
commit 58ad14ff96e68715ccd13b6e1205a96503d1bfc5
5 changes: 3 additions & 2 deletions apps/comments/src/mixins/CommentView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export default defineComponent({
key: 'editor',
},
userData: {},
currentResourceId: this.resourceId,
}
},
methods: {
Expand All @@ -40,8 +41,8 @@ export default defineComponent({
const { data } = await axios.get(generateOcsUrl('core/autocomplete/get'), {
params: {
search,
itemType: 'files',
itemId: this.resourceId,
itemType: this.resourceType,
itemId: this.currentResourceId,
sorter: 'commenters|share-recipients',
limit: loadState('comments', 'maxAutoCompleteResults'),
},
Expand Down
1 change: 0 additions & 1 deletion apps/comments/src/views/Comments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ export default {
loading: false,
done: false,

currentResourceId: this.resourceId,
offset: 0,
comments: [],

Expand Down