Skip to content

[stable31] Fix comments when used by other apps #55664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 5 commits into from
Oct 10, 2025
Merged

[stable31] Fix comments when used by other apps #55664

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3120a48
fix(comments): Use the correct object when autocompleting mentions fo…
nickvergessen Oct 9, 2025
95704cd
fix(comments): Correctly await the getComments() call
nickvergessen Oct 9, 2025
bc2bd4c
fix(comments): Support user IDs that are numbers, e.g. "42"
nickvergessen Oct 9, 2025
d9311be
fix(comments): Don't throw type error when no itemType or itemId is g…
nickvergessen Oct 9, 2025
a3790c6
chore(assets): Recompile assets
nextcloud-command Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(comments): Support user IDs that are numbers, e.g. "42" 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Oct 10, 2025
commit bc2bd4cf7baa3952c1c4c83bcaa3996e11959487
7 changes: 6 additions & 1 deletion apps/comments/src/views/Comments.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,13 @@ export default {
this.done = true
}

// Ensure actor id is a string
for (const comment of comments) {
comment.props.actorId = comment.props.actorId.toString()
}

// Insert results
this.comments.push(...comments)
this.comments = [...this.comments, ...comments]

// Increase offset for next fetch
this.offset += DEFAULT_LIMIT
Expand Down