Skip to content

[stable32] fix(contacts): Do not expose SAB in /contactsmenu #55700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Oct 11, 2025
Merged

[stable32] fix(contacts): Do not expose SAB in /contactsmenu #55700

provokateurin merged 1 commit into from
Oct 11, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 11, 2025 •
edited
Loading

@artonge @backportbot
fix(contacts): Do not expose SAB in /contactsmenu
dd1ad9a 
When hitting the `/contactsmenu/contacts` endpoint with the `dav.system_addressbook_exposed` config switch set to `"no"`, the system address book content is still listed in the response.

This ensure that we do not expose unexpectedly the system address book.

Signed-off-by: Louis Chemineau <[email protected]>
@backportbot backportbot bot requested a review from ChristophWurst October 11, 2025 11:12
@backportbot backportbot bot requested a review from hamza221 as a code owner October 11, 2025 11:12
@backportbot backportbot bot requested a review from kesselb October 11, 2025 11:12
@backportbot backportbot bot requested review from a team and SebastianKrupinski as code owners October 11, 2025 11:12
@backportbot backportbot bot requested review from ArtificialOwl, artonge, provokateurin and sorbaugh and removed request for a team October 11, 2025 11:12
@backportbot backportbot bot added bug 3. to review Waiting for reviews php Pull requests that update Php code feature: contacts labels Oct 11, 2025
@backportbot backportbot bot added this to the Nextcloud 32.0.1 milestone Oct 11, 2025
@provokateurin provokateurin merged commit 9319764 into stable32 Oct 11, 2025
206 of 209 checks passed
@provokateurin provokateurin deleted the backport/55657/stable32 branch October 11, 2025 16:35
@blizzz blizzz mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@provokateurin provokateurin provokateurin approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@kesselb kesselb Awaiting requested review from kesselb

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug feature: contacts php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 32.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @provokateurin