[stable29] fix(contacts): Do not expose SAB in /contactsmenu
#55702
+38
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
3. to review
artonge
force-pushed
the
backport/55657/stable29
branch
from
7784624 to
7b33685
Compare
artonge
approved these changes
Oct 11, 2025
artonge
force-pushed
the
backport/55657/stable29
branch
2 times, most recently
from
2224213 to
41ab2d6
Compare
ChristophWurst
requested review from
SebastianKrupinski and
hamza221
as code owners
ChristophWurst
requested changes
Oct 13, 2025
When hitting the `/contactsmenu/contacts` endpoint with the `dav.system_addressbook_exposed` config switch set to `"no"`, the system address book content is still listed in the response. This ensure that we do not expose unexpectedly the system address book. Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
backport/55657/stable29
branch
2 times, most recently
from
cba674d to
72c2aef
Compare
Signed-off-by: Louis Chmn <[email protected]>
ChristophWurst
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #55657
Warning, This backport had conflicts that were resolved with the⚠️
oursmerge strategy and is likely incompleteTodo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.