feat(TaskProcessing): user-facing error messages #55713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyteinsky
reviewed
Oct 13, 2025
julien-nc
reviewed
Oct 14, 2025
marcelklehr
force-pushed
the
feat/taskprocessing/user-facing-error-message
branch
from
1cbb10f to
bc0609a
Compare
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
…r messages Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Anupam Kumar <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/taskprocessing/user-facing-error-message
branch
from
bc0609a to
2b93d2c
Compare
marcelklehr
requested review from
ArtificialOwl and
come-nc
and removed request for
a team
to make it easier to use this across nextcloud versions Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
feat/taskprocessing/user-facing-error-message
branch
from
2b93d2c to
3f52766
Compare
oleksandr-nc
approved these changes
Oct 20, 2025
Contributor
There was a problem hiding this comment.
Should we add Consumable attribute?
Interfaces, Enums and classes that have the OCP\AppFramework\Attribute\Consumable attribute, must only be consumed by apps and can not be implemented by apps themselves. This means the server side can extend the interface with new methods or reduce returned types of existing methods without it being consider an API break.
Reference: https://docs.nextcloud.com/server/latest/developer_manual///digging_deeper/api.html#php-public-api
Signed-off-by: Marcel Klehr <[email protected]>
julien-nc
approved these changes
Oct 27, 2025
This allows for cutting them to longer lengths Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
This was referenced Nov 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the task processing API only had internal error messages that are not safe to show to the user. This PR extends it so that providers can also set user-facing error messages.
Checklist
3. to review, feature component)stable32)