fix(settings): Improve TaskProcessingPickupSpeed setup check #55715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
requested review from
ArtificialOwl,
leftybournes and
yemkareems
and removed request for
a team
Signed-off-by: Marcel Klehr <[email protected]>
kyteinsky
approved these changes
Oct 13, 2025
Signed-off-by: Marcel Klehr <[email protected]>
julien-nc
approved these changes
Oct 14, 2025
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Optional changes. Otherwise, Lgtm
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Member
Author
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of the task processing pick up speed setup check is not ideal, as it will return success if no tasks have been submitted in the last day, which may however, be a result of the tasks taking a long time. Thus I've rewritten the setup check here to go back multiple days if it doesn't find any tasks.
Checklist
3. to review, feature component)stable32)