Skip to content

[stable32] fix(settings): Improve TaskProcessingPickupSpeed setup check #55749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 5 commits into from
Oct 16, 2025
Merged

[stable32] fix(settings): Improve TaskProcessingPickupSpeed setup check #55749

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7dc7368
fix(settings): Improve TaskProcessingPickupSpeed setup check
marcelklehr Oct 13, 2025
bc30bd8
fix: Run cs:fix
marcelklehr Oct 13, 2025
297f61b
fix: Change messages to use days instead of hours
marcelklehr Oct 14, 2025
baf0a24
fix: Apply suggestion from @julien-nc
marcelklehr Oct 14, 2025
7f9af58
fix: Apply suggestion from @julien-nc
marcelklehr Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Change messages to use days instead of hours 
Signed-off-by: Marcel Klehr <[email protected]>
  • Loading branch information
@marcelklehr @AndyScherzinger
marcelklehr authored and AndyScherzinger committed Oct 15, 2025
commit 297f61b619e3b5ba8bce2efe726d24f412b40abd
18 changes: 9 additions & 9 deletions apps/settings/lib/SetupChecks/TaskProcessingPickupSpeed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public function run(): SetupResult {
if ($taskCount === 0) {
return SetupResult::success(
$this->l10n->n(
'No scheduled tasks in the last %n hour.',
'No scheduled tasks in the last %n hours.',
24 * $lastNDays
'No scheduled tasks in the last day.',
'No scheduled tasks in the last %n days.',
$lastNDays
)
);
}
Expand All @@ -69,17 +69,17 @@ public function run(): SetupResult {
if ($slowCount / $taskCount < self::MAX_SLOW_PERCENTAGE) {
return SetupResult::success(
$this->l10n->n(
'The task pickup speed has been ok in the last %n hour.',
'The task pickup speed has been ok in the last %n hours.',
24 * $lastNDays
'The task pickup speed has been ok in the last day.',
'The task pickup speed has been ok in the last %n days.',
$lastNDays
)
);
} else {
return SetupResult::warning(
$this->l10n->n(
'The task pickup speed has been slow in the last %n hour. Many tasks took longer than 4 minutes to be picked up. Consider setting up a worker to process tasks in the background.',
'The task pickup speed has been slow in the last %n hours. Many tasks took longer than 4 minutes to be picked up. Consider setting up a worker to process tasks in the background.',
24 * $lastNDays
'The task pickup speed has been slow in the last day. Many tasks took longer than 4 minutes to be picked up. Consider setting up a worker to process tasks in the background.',
'The task pickup speed has been slow in the last %n days. Many tasks took longer than 4 minutes to be picked up. Consider setting up a worker to process tasks in the background.',
$lastNDays
),
'https://docs.nextcloud.com/server/latest/admin_manual/ai/overview.html#improve-ai-task-pickup-speed'
);
Expand Down