fix(sharing): Allow public share access for everyone #55811
Merged
+118
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
Altahrim,
provokateurin and
yemkareems
and removed request for
a team
nfebe
added a commit
that referenced
this pull request
Oct 17, 2025
Following #55811 split `shareApiAllowLinks()` into two dedicated methods to improve clarity and separation of concerns: - `isLinkSharingEnabled()`: Checks if link sharing is globally enabled - `canUserCreateLinkShares()`: Checks if a user can create link shares (considers both global settings and group restrictions) The original shareApiAllowLinks() is now deprecated and acts as a wrapper to maintain backward compatibility.
artonge
reviewed
Oct 17, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
I think we should rather change the check to check whether the share owner can create links. This would allow preventing access to a share if the share owner is prevented to create links after it was created.
nfebe
force-pushed
the
fix/public-share-group-exclusion-access
branch
from
7a9c04a to
ea29e2f
Compare
nfebe
force-pushed
the
fix/public-share-group-exclusion-access
branch
from
ea29e2f to
e222c83
Compare
provokateurin
requested changes
Nov 17, 2025
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
Member
|
/backport to stable30 |
nfebe
force-pushed
the
fix/public-share-group-exclusion-access
branch
from
e222c83 to
ed0d841
Compare
nfebe
force-pushed
the
fix/public-share-group-exclusion-access
branch
from
ed0d841 to
5aa8a64
Compare
juliusknorr
force-pushed
the
fix/public-share-group-exclusion-access
branch
from
5aa8a64 to
ca7755f
Compare
juliusknorr
approved these changes
Nov 27, 2025
provokateurin
requested changes
Dec 2, 2025
When a logged-in user accesses a public share link in the same browser, the system was incorrectly checking if that user's groups were excluded from creating link shares. This caused share not found errors for users in excluded groups, even though public shares should be accessible to anyone with the link. The group exclusion setting (`shareapi_allow_links_exclude_groups`) is intended to restrict share creation, not share access. Public shares are meant to be anonymous and accessible regardless of the viewer identity or group membership. We now check the exclusion for the share creator and not the viewer. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/public-share-group-exclusion-access
branch
from
ca7755f to
6bccaf7
Compare
provokateurin
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a logged-in user accesses a public share link in the same browser, the system was incorrectly checking if that user's groups were excluded from creating link shares. This caused share not found errors for users in excluded groups, even though public shares should be accessible to anyone with the link.
The group exclusion setting (
shareapi_allow_links_exclude_groups) is intended to restrict share creation, not share access. Public shares are meant to be anonymous and accessible regardless of the viewer identity or group membership.