Skip to content

Conversation

@victorlap
Copy link
Contributor

@victorlap victorlap commented Oct 18, 2025

Summary

This PR adds font-variant-numeric to selected files list, so the text doesn't jump around when selecting multiple files.

Screenshots

Before

Screen.Recording.2025-10-18.at.13.45.24.mov

After

Screen.Recording.2025-10-18.at.13.45.00.mov

Checklist

@victorlap victorlap requested review from a team and skjnldsv as code owners October 18, 2025 11:51
@victorlap victorlap requested review from susnux and szaimen and removed request for a team October 18, 2025 11:51
@AndyScherzinger AndyScherzinger added bug 3. to review Waiting for reviews labels Oct 18, 2025
@AndyScherzinger AndyScherzinger added this to the Nextcloud 33 milestone Oct 18, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@susnux susnux requested a review from kra-mo October 19, 2025 14:20
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the screen recording. Thanks! :)

(but did not test)

@AndyScherzinger

This comment was marked as resolved.

@skjnldsv
Copy link
Member

Nice! TIL

@skjnldsv

This comment was marked as duplicate.

@backportbot

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@backportbot

This comment was marked as resolved.

@skjnldsv
Copy link
Member

Ah, we cannot use the bot to create clone branches, I forgot that doesn't work

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 21, 2025
@AndyScherzinger

This comment was marked as outdated.

@skjnldsv skjnldsv self-assigned this Oct 21, 2025
@skjnldsv skjnldsv merged commit 1c57699 into nextcloud:master Oct 21, 2025
111 of 114 checks passed
@welcome
Copy link

welcome bot commented Oct 21, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv
Copy link
Member

/backport to stable32

@susnux
Copy link
Contributor

susnux commented Oct 22, 2025

/backport to stable31

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "n selected" does not use tnum

5 participants