fix(dav): Allow array of array of scalars, and fix error message

Signed-off-by: Côme Chilliet <[email protected]>

apps/dav/lib/DAV/CustomPropertiesBackend.php

@@ -435,6 +435,18 @@
 		return $path;
 	}
 
+	private static function checkIsArrayOfScalar(string $name, array $array): void {
+		foreach ($array as $item) {
+			if (is_array($item)) {
+				self::checkIsArrayOfScalar($name, $item);
+			} elseif ($item !== null && !is_scalar($item)) {
+				throw new DavException(
+					"Property \"$name\" has an invalid value of array containing " . gettype($item),
+				);
+			}
+		}
+	}
+
 	/**
 	 * @param mixed $value
 	 * @return array
@@ -443,30 +455,25 @@
 		if (is_scalar($value)) {
 			$valueType = self::PROPERTY_TYPE_STRING;
 		} elseif ($value instanceof Complex) {
 			$valueType = self::PROPERTY_TYPE_XML;
 			$value = $value->getXml();
 		} else {
 			if (is_array($value)) {
 				// For array only allow scalar values
-				foreach ($value as $item) {
-					if (!is_scalar($item)) {
-						throw new DavException(
-							"Property \"$name\" has an invalid value of array containing " . gettype($value),
-						);
-					}
-				}
+				self::checkIsArrayOfScalar($name, $value);
 			} elseif (!is_object($value)) {
 				throw new DavException(
 					"Property \"$name\" has an invalid value of type " . gettype($value),
 				);
-			}
-			if (!str_starts_with($value::class, 'Sabre\\DAV\\Xml\\Property\\')
-				&& !str_starts_with($value::class, 'Sabre\\CalDAV\\Xml\\Property\\')
-				&& !str_starts_with($value::class, 'Sabre\\CardDAV\\Xml\\Property\\')
-				&& !str_starts_with($value::class, 'OCA\\DAV\\')) {
-				throw new DavException(
-					"Property \"$name\" has an invalid value of class " . $value::class,
-				);
+			} else {
+				if (!str_starts_with($value::class, 'Sabre\\DAV\\Xml\\Property\\')
+					&& !str_starts_with($value::class, 'Sabre\\CalDAV\\Xml\\Property\\')
+					&& !str_starts_with($value::class, 'Sabre\\CardDAV\\Xml\\Property\\')
+					&& !str_starts_with($value::class, 'OCA\\DAV\\')) {
+					throw new DavException(
+						"Property \"$name\" has an invalid value of class " . $value::class,
+					);
+				}
 			}
 			$valueType = self::PROPERTY_TYPE_OBJECT;
 			// serialize produces null character