Skip to content

[stable32] fix(FilesPicker): Prevent selection of nodes without create permission #55898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 3 commits into from
Oct 23, 2025
Merged

[stable32] fix(FilesPicker): Prevent selection of nodes without create permission #55898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa01bbc
fix(FilesPicker): Prevent selection of nodes without create permission
artonge Oct 17, 2025
8a22bca
chore(deps): Bump @nextcloud/dialogs to v6.4.1
artonge Oct 22, 2025
d106205
chore(assets): Recompile assets
nextcloud-command Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/files/src/actions/moveOrCopyAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ async function openFilePickerForAction(
// We don't want to show the current nodes in the file picker
return !fileIDs.includes(n.fileid)
})
.setCanPick((n) => {
const hasCreatePermissions = (n.permissions & Permission.CREATE) === Permission.CREATE
return hasCreatePermissions
})
.setMimeTypeFilter([])
.setMultiSelect(false)
.startAt(dir)
Expand All @@ -236,7 +240,6 @@ async function openFilePickerForAction(
label: target ? t('files', 'Copy to {target}', { target }, undefined, { escape: false, sanitize: false }) : t('files', 'Copy'),
type: 'primary',
icon: CopyIconSvg,
disabled: selection.some((node) => (node.permissions & Permission.CREATE) === 0),
async callback(destination: Node[]) {
resolve({
destination: destination[0] as Folder,
Expand Down
2 changes: 1 addition & 1 deletion core/css/server.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading