Skip to content

[stable31] fix(FilesPicker): Prevent selection of nodes without create permission #55899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 3 commits into from
Oct 23, 2025
Merged

[stable31] fix(FilesPicker): Prevent selection of nodes without create permission #55899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
596874a
fix(FilesPicker): Prevent selection of nodes without create permission
artonge Oct 22, 2025
1569ef4
chore(deps): Bump @nextcloud/dialogs to v6.4.1
artonge Oct 22, 2025
1d335ec
chore(assets): Recompile assets
nextcloud-command Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/files/src/actions/moveOrCopyAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ async function openFilePickerForAction(
// We don't want to show the current nodes in the file picker
return !fileIDs.includes(n.fileid)
})
.setCanPick((n) => {
const hasCreatePermissions = (n.permissions & Permission.CREATE) === Permission.CREATE
return hasCreatePermissions
})
.setMimeTypeFilter([])
.setMultiSelect(false)
.startAt(dir)
Expand All @@ -237,7 +241,6 @@ async function openFilePickerForAction(
label: target ? t('files', 'Copy to {target}', { target }, undefined, { escape: false, sanitize: false }) : t('files', 'Copy'),
type: 'primary',
icon: CopyIconSvg,
disabled: selection.some((node) => (node.permissions & Permission.CREATE) === 0),
async callback(destination: Node[]) {
resolve({
destination: destination[0] as Folder,
Expand Down
4 changes: 2 additions & 2 deletions core/css/server.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/css/server.css.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/1252-1252.js
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 7 additions & 4 deletions dist/1252-1252.js.license
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,14 @@ SPDX-FileCopyrightText: @nextcloud/dialogs developers


This file is generated from multiple sources. Included packages:
- @nextcloud/browser-storage
- version: 0.5.0
- license: GPL-3.0-or-later
- @nextcloud/auth
- version: 2.5.1
- version: 2.5.3
- license: GPL-3.0-or-later
- @nextcloud/axios
- version: 2.5.1
- version: 2.5.2
- license: GPL-3.0-or-later
- @nextcloud/browser-storage
- version: 0.4.0
Expand All @@ -50,7 +53,7 @@ This file is generated from multiple sources. Included packages:
- version: 1.2.0
- license: GPL-3.0-or-later
- @nextcloud/dialogs
- version: 6.3.1
- version: 6.4.1
- license: AGPL-3.0-or-later
- semver
- version: 7.6.3
Expand Down Expand Up @@ -92,7 +95,7 @@ This file is generated from multiple sources. Included packages:
- version: 11.3.0
- license: MIT
- axios
- version: 1.9.0
- version: 1.12.2
- license: MIT
- base64-js
- version: 1.5.1
Expand Down
2 changes: 1 addition & 1 deletion dist/1252-1252.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/1642-1642.js.license
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ SPDX-FileCopyrightText: Anthony Fu <https://github.com/antfu>


This file is generated from multiple sources. Included packages:
- @nextcloud/browser-storage
- version: 0.5.0
- license: GPL-3.0-or-later
- @nextcloud/auth
- version: 2.5.1
- version: 2.5.3
- license: GPL-3.0-or-later
- @nextcloud/axios
- version: 2.5.1
- license: GPL-3.0-or-later
- @nextcloud/browser-storage
- version: 0.4.0
- version: 2.5.2
- license: GPL-3.0-or-later
- semver
- version: 7.6.3
Expand Down Expand Up @@ -59,7 +59,7 @@ This file is generated from multiple sources. Included packages:
- version: 11.3.0
- license: MIT
- axios
- version: 1.9.0
- version: 1.12.2
- license: MIT
- base64-js
- version: 1.5.1
Expand Down
14 changes: 7 additions & 7 deletions dist/1656-1656.js.license
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,20 @@ SPDX-FileCopyrightText: @nextcloud/dialogs developers


This file is generated from multiple sources. Included packages:
- @nextcloud/browser-storage
- version: 0.5.0
- license: GPL-3.0-or-later
- @nextcloud/auth
- version: 2.5.1
- version: 2.5.3
- license: GPL-3.0-or-later
- @nextcloud/axios
- version: 2.5.1
- license: GPL-3.0-or-later
- @nextcloud/browser-storage
- version: 0.4.0
- version: 2.5.2
- license: GPL-3.0-or-later
- @nextcloud/capabilities
- version: 1.2.0
- license: GPL-3.0-or-later
- @nextcloud/dialogs
- version: 6.3.1
- version: 6.4.1
- license: AGPL-3.0-or-later
- semver
- version: 7.6.3
Expand Down Expand Up @@ -98,7 +98,7 @@ This file is generated from multiple sources. Included packages:
- version: 4.5.0
- license: Apache-2.0
- axios
- version: 1.9.0
- version: 1.12.2
- license: MIT
- base64-js
- version: 1.5.1
Expand Down
4 changes: 2 additions & 2 deletions dist/2452-2452.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions dist/2452-2452.js.license
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ SPDX-FileCopyrightText: Anthony Fu <https://github.com/antfu>


This file is generated from multiple sources. Included packages:
- @nextcloud/browser-storage
- version: 0.5.0
- license: GPL-3.0-or-later
- @nextcloud/auth
- version: 2.5.1
- version: 2.5.3
- license: GPL-3.0-or-later
- @nextcloud/axios
- version: 2.5.1
- license: GPL-3.0-or-later
- @nextcloud/browser-storage
- version: 0.4.0
- version: 2.5.2
- license: GPL-3.0-or-later
- semver
- version: 7.6.3
Expand All @@ -53,7 +53,7 @@ This file is generated from multiple sources. Included packages:
- version: 11.3.0
- license: MIT
- axios
- version: 1.9.0
- version: 1.12.2
- license: MIT
- base64-js
- version: 1.5.1
Expand Down
2 changes: 1 addition & 1 deletion dist/2452-2452.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions dist/2979-2979.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/2979-2979.js.map
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/2979-2979.js.map.license
View file
Open in desktop

This file was deleted.

Loading
Loading