Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 3, 2017

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @icewind1991 and @LukasReschke to be potential reviewers.

@MorrisJobke MorrisJobke force-pushed the move-client-info-to-firstrunwizard branch from 46987a2 to da6dd48 Compare July 4, 2017 08:54
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the autoloader test failures and it works fine 👍

@codecov
Copy link

codecov bot commented Jul 4, 2017

Codecov Report

Merging #5591 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #5591      +/-   ##
===========================================
+ Coverage     53.98%     54%   +0.01%     
+ Complexity    22466   22460       -6     
===========================================
  Files          1390    1388       -2     
  Lines         85980   85947      -33     
  Branches       1329    1329              
===========================================
- Hits          46419   46412       -7     
+ Misses        39561   39535      -26
Impacted Files Coverage Δ Complexity Δ
lib/private/Settings/Manager.php 46.8% <ø> (+0.15%) 72 <0> (-1) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Security/CertificateManager.php 90.81% <0%> (-1.03%) 39% <0%> (ø)
core/js/js.js 61.27% <0%> (-0.56%) 0% <0%> (ø)
lib/private/Server.php 93.5% <0%> (+0.14%) 120% <0%> (ø) ⬇️

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 4, 2017
@MorrisJobke MorrisJobke merged commit 8e160c6 into master Jul 4, 2017
@MorrisJobke MorrisJobke deleted the move-client-info-to-firstrunwizard branch July 4, 2017 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants