fix(dav): allow multiple link shares token in session #55955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
3. to review
skjnldsv
requested review from
Altahrim,
artonge,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
skjnldsv
force-pushed
the
fix/multiple-dav-public-auth
branch
3 times, most recently
from
044fc3d to
00b3486
Compare
artonge
approved these changes
Oct 23, 2025
tests/lib/AppFramework/Controller/PublicShareControllerTest.php
Outdated
Show resolved
Hide resolved
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
fix/multiple-dav-public-auth
branch
from
00b3486 to
9c98b72
Compare
CarlSchwan
approved these changes
Oct 23, 2025
Member
|
/backport to stable31 |
Member
|
/backport to stable32 |
This was referenced Oct 23, 2025
This was referenced Nov 26, 2025
Member
|
The change of the session value seems to have caused some regressions with other apps, though one could consider this internal implementation that should not be used anywhere else, we have quite a few ones that should be checked: https://github.com/search?q=org%3Anextcloud%20public_link_authenticated&type=code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously: we set the session based on the password/share combo. Accessing a new one will override the previous one.
Now: we store the allowed tokens in an array.
Checklist
3. to review, feature component)stable32)