fix: avoid outer "uncaught exception" for ServerMaintenanceMode #55969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already exclude ServerMaintenanceMode in the inner logger, but there are some spots where it can can bubble up still via DAV. Fixes #55894 Signed-off-by: Josh <[email protected]>
joshtrichards
added
bug
3. to review
joshtrichards
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
Contributor
|
I can't fully explain why, but I'd prefer to fix this in remote.php's handleException. I think we already handle it in the else block, but it looks like the special handling for ServiceUnavailableException is missing for XML requests. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already exclude ServerMaintenanceMode in the inner logger, but there are some spots where it can can bubble up still via DAV.
TODO
Checklist
3. to review, feature component)stable32)