Skip to content

fix(Dav): make absenceform textarea not overlap #56055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GVodyanov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(Dav): make absenceform textarea not overlap #56055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32ffe5
fix(Dav): make absenceform textarea not overlap
GVodyanov Oct 28, 2025
5d2bf1f
chore(assets): Recompile assets
nextcloud-command Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion apps/dav/src/components/AbsenceForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
:options="options"
@search="asyncFind" />
<NcTextField v-model="status" :label="t('dav', 'Short absence status')" :required="true" />
<NcTextArea v-model="message" :label="t('dav', 'Long absence Message')" :required="true" />
<div class="absence-long-message__wrapper">
Copy link
Contributor

@hamza221 hamza221 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any DOM node within a block can be an element. Within a given block, all elements are semantically equal.

https://getbem.com/naming/

Elements should be inside blocks not the other way around

Copy link
Contributor

@susnux susnux Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just rename to

  • absence-long-message
  • absence-long-message__input

<NcTextArea input-class="absence-long-message" v-model="message" :label="t('dav', 'Long absence Message')" :required="true" resize="none" rows="6"/>
</div>

<div class="absence__buttons">
<NcButton
Expand Down Expand Up @@ -271,6 +273,17 @@ export default {
}
}

.absence-long-message {
height: calc(var(--default-line-height) * 6 * var(--font-size-small));

&__wrapper {
height: calc(var(--default-line-height) * 6 * var(--font-size-small) + var(--default-grid-baseline) * 2);
display: flex;
flex-direction: column;
justify-content: start;
}
}

&__buttons {
display: flex;
gap: 5px;
Expand Down
1 change: 1 addition & 0 deletions dist/dav-dav-settings-personal-availability-BdZQgwwQ.chunk.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion dist/dav-dav-settings-personal-availability-Cj5tXAon.chunk.css
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion dist/dav-settings-personal-availability.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* extracted by css-entry-points-plugin */
@import './dav-dav-settings-personal-availability-Cj5tXAon.chunk.css';
@import './dav-dav-settings-personal-availability-BdZQgwwQ.chunk.css';
@import './NcSettingsSection-DFav6ob5-BFoYkIs3.chunk.css';
@import './check-seKZqyL0.chunk.css';
22 changes: 11 additions & 11 deletions dist/dav-settings-personal-availability.mjs
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/dav-settings-personal-availability.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.