Skip to content

fix(files_sharing): Hide 'Open locally' action #56060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Nov 28, 2025
Merged

fix(files_sharing): Hide 'Open locally' action #56060

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7509ae
fix(files_sharing): Hide 'Open locally' action
fauzanfebrian Oct 24, 2025
7bbc428
fix(files): use `isDownloadable` for `isSyncable`
skjnldsv Nov 28, 2025
478509a
chore(assets): Recompile assets
skjnldsv Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files): use isDownloadable for isSyncable 
Signed-off-by: John Molakvoæ <[email protected]>
  • Loading branch information
@skjnldsv
skjnldsv committed Nov 28, 2025
commit 7bbc42809e935b70a613b85c107e2d05e04fa329
22 changes: 5 additions & 17 deletions apps/files/src/utils/permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,33 +37,21 @@ export function isDownloadable(node: Node): boolean {
return true
}


/**
* Check permissions on the node if it can be synced/open locally
*
* @param node The node to check
* @return True if syncable, false otherwise
*/
export function isSyncable(node: Node): boolean {
if ((node.permissions & Permission.UPDATE) === 0) {
if (!node.isDavResource) {
return false
}

// check hide-download property of shares
if (node.attributes['hide-download'] === true
|| node.attributes['hide-download'] === 'true'
) {
if ((node.permissions & Permission.UPDATE) === 0) {
return false
}

// If the mount type is a share, ensure it got download permissions.
if (node.attributes['share-attributes']) {
const shareAttributes = JSON.parse(node.attributes['share-attributes'] || '[]') as Array<ShareAttribute>
const downloadAttribute = shareAttributes.find(({ scope, key }: ShareAttribute) => scope === 'permissions' && key === 'download')
if (downloadAttribute !== undefined) {
return downloadAttribute.value === true
}
}

return true
}
// Syncable has the same permissions as downloadable for now
return isDownloadable(node)
}