Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 5, 2025

With SSO setups users may otherwise be redirected to the IdP directly
instead of the regular login form that they reset the password for

This is a regression from 9b5608f

To test:

  • Setup user_saml app or user_oidc configured to directly redirect to the IdP
  • Open /index.php/login?direct=1 and reset the password for a local user account

@juliusknorr juliusknorr requested a review from a team as a code owner November 5, 2025 20:27
@juliusknorr juliusknorr requested review from SebastianKrupinski, nfebe, sorbaugh and szaimen and removed request for a team November 5, 2025 20:27
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug labels Nov 5, 2025
@juliusknorr
Copy link
Member Author

/backport to stable32

@juliusknorr
Copy link
Member Author

/backport to stable31

@juliusknorr
Copy link
Member Author

/backport to stable30

@juliusknorr juliusknorr force-pushed the fix/direct-login-after-password-reset branch from 3540385 to ad82014 Compare November 5, 2025 21:18
@juliusknorr
Copy link
Member Author

/compile

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen szaimen added this to the Nextcloud 33 milestone Nov 6, 2025
juliusknorr and others added 2 commits November 6, 2025 13:04
With SSO setups users may otherwise be redirected to the IdP directly
instead of the regular login form that they reset the password for

Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr force-pushed the fix/direct-login-after-password-reset branch from b9affc3 to 0fdedc8 Compare November 6, 2025 12:04
@juliusknorr juliusknorr merged commit e67f8e2 into master Nov 6, 2025
124 checks passed
@juliusknorr juliusknorr deleted the fix/direct-login-after-password-reset branch November 6, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants