Skip to content

fix(l10n): Nicer capitalization for generic messages #56283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kra-mo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(l10n): Nicer capitalization for generic messages #56283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/files/src/components/FilesListTableHeaderActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,16 +316,16 @@ export default defineComponent({
return
}

showError(this.t('files', '{displayName}: failed on some elements', { displayName }))
showError(this.t('files', '{displayName}: Failed on some elements', { displayName }))
return
}

// Show success message and clear selection
showSuccess(this.t('files', '{displayName}: done', { displayName }))
showSuccess(this.t('files', '{displayName}: Done', { displayName }))
this.selectionStore.reset()
} catch (e) {
logger.error('Error while executing action', { action, e })
showError(this.t('files', '{displayName}: failed', { displayName }))
showError(this.t('files', '{displayName}: Failed', { displayName }))
} finally {
// Remove loading markers
this.loading = null
Expand Down
6 changes: 3 additions & 3 deletions apps/files/src/utils/actionUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ export async function executeAction(action: FileAction) {
}

if (success) {
showSuccess(t('files', '{displayName}: done', { displayName }))
showSuccess(t('files', '{displayName}: Done', { displayName }))
return
}
showError(t('files', '{displayName}: failed', { displayName }))
showError(t('files', '{displayName}: Failed', { displayName }))
} catch (error) {
logger.error('Error while executing action', { action, error })
showError(t('files', '{displayName}: failed', { displayName }))
showError(t('files', '{displayName}: Failed', { displayName }))
} finally {
// Reset the loading marker
Vue.set(currentNode, 'status', undefined)
Expand Down
6 changes: 3 additions & 3 deletions apps/files/src/views/FilesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,13 +830,13 @@ export default defineComponent({
}

if (success) {
showSuccess(t('files', '{displayName}: done', { displayName }))
showSuccess(t('files', '{displayName}: Done', { displayName }))
return
}
showError(t('files', '{displayName}: failed', { displayName }))
showError(t('files', '{displayName}: Failed', { displayName }))
} catch (error) {
logger.error('Error while executing action', { action, error })
showError(t('files', '{displayName}: failed', { displayName }))
showError(t('files', '{displayName}: Failed', { displayName }))
} finally {
this.loadingAction = null
}
Expand Down
Loading