Skip to content

Add rememberme checkbox #56343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorbaugh merged 4 commits into from
Nov 13, 2025
Merged

Add rememberme checkbox #56343

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28b48ee
chore: Improve typing and codestyle in LoginData
come-nc Nov 10, 2025
4e83d20
feat(login): Add rememberme checkbox
come-nc Nov 10, 2025
f99ca7d
chore(login): Check remember me by default
come-nc Nov 13, 2025
907fb19
chore(assets): Recompile assets
nextcloud-command Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: Improve typing and codestyle in LoginData 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
  • Loading branch information
@come-nc @nextcloud-command
come-nc authored and nextcloud-command committed Nov 13, 2025
commit 28b48eec398c86e55b4a7d0436248bc940e5069c
44 changes: 11 additions & 33 deletions lib/private/Authentication/Login/LoginData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,48 +6,26 @@
* SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OC\Authentication\Login;

use OCP\IRequest;
use OCP\IUser;

class LoginData {
/** @var IRequest */
private $request;

/** @var string */
private $username;

/** @var string */
private $password;

/** @var string */
private $redirectUrl;

/** @var string */
private $timeZone;

/** @var string */
private $timeZoneOffset;

/** @var IUser|false|null */
private $user = null;

/** @var bool */
private $rememberLogin = true;
private bool $rememberLogin = true;

public function __construct(IRequest $request,
string $username,
?string $password,
?string $redirectUrl = null,
string $timeZone = '',
string $timeZoneOffset = '') {
$this->request = $request;
$this->username = $username;
$this->password = $password;
$this->redirectUrl = $redirectUrl;
$this->timeZone = $timeZone;
$this->timeZoneOffset = $timeZoneOffset;
public function __construct(
private IRequest $request,
private string $username,
private ?string $password,
private ?string $redirectUrl = null,
private string $timeZone = '',
private string $timeZoneOffset = '',
) {
}

public function getRequest(): IRequest {
Expand Down Expand Up @@ -81,7 +59,7 @@ public function getTimeZoneOffset(): string {
/**
* @param IUser|false|null $user
*/
public function setUser($user) {
public function setUser($user): void {
$this->user = $user;
}

Expand Down