Skip to content

Conversation

@yemkareems
Copy link
Contributor

possible options now are

occ encryption:encrypt-all

will ask the confirmation question before proceeding with encryption

occ encryption:encrypt-all -n

will not ask the question and run the encryption directly

  • Resolves: #

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems self-assigned this Nov 13, 2025
@yemkareems yemkareems requested a review from a team as a code owner November 13, 2025 14:26
@yemkareems yemkareems added the 3. to review Waiting for reviews label Nov 13, 2025
@yemkareems yemkareems requested review from Altahrim and icewind1991 and removed request for a team November 13, 2025 14:26
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's going in the good direction :).
Don't forget the other question that comes later.

…run encryption non-interactive only when -n option is present

Signed-off-by: yemkareems <[email protected]>
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also that question:

$question = new ConfirmationQuestion('Do you want to send the passwords directly to the users by mail? (y/n) ', false);
if ($this->questionHelper->ask($this->input, $this->output, $question)) {
$this->sendPasswordsByMail();
}
}

…non-interactive mode sent the password directly

Signed-off-by: yemkareems <[email protected]>
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option --no-interaction is provided by symfony for all console commands.
So the only thing you need to do is to remove the warning to prevent non-interactive input. Ideally make sure to only remove the warning if the option is passed.

…ault answer to both questions true to support -n run directly

Signed-off-by: yemkareems <[email protected]>
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good beside nitpick

@yemkareems yemkareems requested a review from artonge November 20, 2025 06:04
@sorbaugh sorbaugh merged commit fbff470 into master Nov 27, 2025
182 of 188 checks passed
@sorbaugh sorbaugh deleted the fix/provide-non-interactive-mode-to-run-encryption branch November 27, 2025 10:46
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants