Skip to content

[stable32] Add rememberme checkbox #56423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 5 commits into from
Nov 17, 2025
Merged

[stable32] Add rememberme checkbox #56423

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
247b608
chore: Improve typing and codestyle in LoginData
come-nc Nov 10, 2025
b51c1d7
feat(login): Add rememberme checkbox
come-nc Nov 10, 2025
fce99ca
chore(login): Check remember me by default
come-nc Nov 13, 2025
7aec2b1
chore(assets): Recompile assets
nextcloud-command Nov 17, 2025
757bed8
fix(tests): Fix login test for remember me checkbox
come-nc Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: Improve typing and codestyle in LoginData 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
  • Loading branch information
@come-nc
come-nc committed Nov 17, 2025
commit 247b60869f8e9cba9d05dfbe8466fa6fb65805da
44 changes: 11 additions & 33 deletions lib/private/Authentication/Login/LoginData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,48 +6,26 @@
* SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

namespace OC\Authentication\Login;

use OCP\IRequest;
use OCP\IUser;

class LoginData {
/** @var IRequest */
private $request;

/** @var string */
private $username;

/** @var string */
private $password;

/** @var string */
private $redirectUrl;

/** @var string */
private $timeZone;

/** @var string */
private $timeZoneOffset;

/** @var IUser|false|null */
private $user = null;

/** @var bool */
private $rememberLogin = true;
private bool $rememberLogin = true;

public function __construct(IRequest $request,
string $username,
?string $password,
?string $redirectUrl = null,
string $timeZone = '',
string $timeZoneOffset = '') {
$this->request = $request;
$this->username = $username;
$this->password = $password;
$this->redirectUrl = $redirectUrl;
$this->timeZone = $timeZone;
$this->timeZoneOffset = $timeZoneOffset;
public function __construct(
private IRequest $request,
private string $username,
private ?string $password,
private ?string $redirectUrl = null,
private string $timeZone = '',
private string $timeZoneOffset = '',
) {
}

public function getRequest(): IRequest {
Expand Down Expand Up @@ -81,7 +59,7 @@ public function getTimeZoneOffset(): string {
/**
* @param IUser|false|null $user
*/
public function setUser($user) {
public function setUser($user): void {
$this->user = $user;
}

Expand Down