Skip to content

fix(files_sharing): Allow deleting a share of a missing file #56498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorbaugh merged 2 commits into from
Nov 25, 2025
Merged

fix(files_sharing): Allow deleting a share of a missing file #56498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a60f949
fix(files_sharing): Allow deleting a share of a missing file
come-nc Nov 17, 2025
cc66d20
chore: Improve wording in debug log
come-nc Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: Improve wording in debug log 
Co-authored-by: Kate <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @provokateurin
come-nc and provokateurin committed Nov 24, 2025
commit cc66d203d4535f5d353b18a389a96c93bd118133
2 changes: 1 addition & 1 deletion apps/files_sharing/lib/Controller/ShareAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ public function deleteShare(string $id): DataResponse {
} catch (LockedException $e) {
throw new OCSNotFoundException($this->l->t('Could not delete share'));
} catch (NotFoundException $e) {
$this->logger->debug('File of deleted share was not found, skip locking', ['exception' => $e]);
$this->logger->debug('File of to be deleted share was not found, skip locking', ['exception' => $e]);
}

if (!$this->canAccessShare($share)) {
Expand Down
Loading