fix(sharing): Add isTrustedServer flag to lookup results #56501
Merged
+37
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
artonge,
come-nc,
maximelehericy and
provokateurin
nfebe
added
3. to review
Contributor
Author
|
/backport to 32 |
Contributor
Author
|
/backport to 31 |
come-nc
approved these changes
Nov 18, 2025
CarlSchwan
approved these changes
Nov 18, 2025
provokateurin
approved these changes
Nov 18, 2025
|
tested and works as expected: |
When `show_federated_shares_to_trusted_servers_as_internal` is enabled, lookup server results were being filtered out because they lacked the `isTrustedServer` flag. This adds the flag to lookup results by: - Injecting TrustedServers service into LookupPlugin - Adding `server` and `isTrustedServer` fields to each lookup result - Updating tests to reflect new structure This ensures lookup results from trusted servers appear in internal sharing while non-trusted servers are correctly filtered out. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/lookup-trusted-server-filter
branch
from
0d88a4f to
40246d9
Compare
|
The backport to # Switch to the target branch and update it
git checkout 31
git pull origin 31
# Create the new backport branch
git checkout -b backport/56501/31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 40246d9a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56501/31Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/56501/31') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout 32
git pull origin 32
# Create the new backport branch
git checkout -b backport/56501/32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 40246d9a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56501/32Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/56501/32') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
show_federated_shares_to_trusted_servers_as_internalis enabled, lookup server results were being filtered out because they lacked theisTrustedServerflag. This adds the flag to lookup results by:serverandisTrustedServerfields to each lookup resultThis ensures lookup results from trusted servers appear in internal sharing while non-trusted servers are correctly filtered out.