Skip to content

fix(files_reminder): prevent setting reminder in the past #56520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Nov 19, 2025
Merged

fix(files_reminder): prevent setting reminder in the past #56520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fee82ad
fix(files_reminder): prevent setting reminder in the past
skjnldsv Nov 19, 2025
32e1d6c
chore(files_reminder): add integration tests
skjnldsv Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/files_reminders/lib/Controller/ApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ public function get(int $fileId): DataResponse {
public function set(int $fileId, string $dueDate): DataResponse {
try {
$dueDate = (new DateTime($dueDate))->setTimezone(new DateTimeZone('UTC'));
$nowDate = (new DateTime('now'))->setTimezone(new DateTimeZone('UTC'));
if ($dueDate <= $nowDate) {
return new DataResponse([], Http::STATUS_BAD_REQUEST);
}
} catch (Exception $e) {
$this->logger->error($e->getMessage(), ['exception' => $e]);
return new DataResponse([], Http::STATUS_BAD_REQUEST);
Expand Down
Loading