refactor(user_status): migrate to Vue 3 #56544

ShGKme · 2025-11-20T01:22:10Z

Part of 📦 ❗️Vue 3 Migration - NC33 Roadmap #55428

Summary

Prerequirement: build: correct render build url in Vite for chunks/assets in dist #56554
Migrates the app to Vue 3
Vue 2 compatible changes are done in an individual commit, backportable
Dirty workarounds:
- AccountMenuEntry is not fully compatible with Vue 3, expecting menu items to be replaced when mounted in place, not to be mounted inside the entry
  - Requires changes in core API to support it
- User statuses are copied from user_status to core to avoid illegal import (core should not depend on an app)
- Some box-sizing: border-box added

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

build/frontend/vite.config.mts

ShGKme · 2025-11-21T16:45:08Z

/compile

szaimen

🐘

susnux · 2025-11-25T10:41:03Z

/compile rebase

ShGKme · 2025-11-25T11:47:48Z

cc @Antreesy as an app owner

susnux · 2025-11-25T12:02:53Z

Added a commit because lint is red unrelated - this will be fixed in a different PR.
So just baseline it here like we did in the other case.
See: ae13758

susnux · 2025-11-25T13:14:42Z

Proper fix: #56660

Antreesy

Works with mentioned changes

apps/user_status/src/components/ClearAtSelect.vue

apps/user_status/src/components/CustomMessageInput.vue

apps/user_status/src/components/PredefinedStatusesList.vue

apps/user_status/src/UserStatus.vue

package.json

apps/user_status/src/components/CustomMessageInput.vue

apps/user_status/src/services/statusOptionsService.js

apps/user_status/src/components/ClearAtSelect.vue

ShGKme · 2025-11-25T16:13:06Z

I was sure, I did all these changes...
I remember fixing value->modelValue before migration and installing debounce v2 for compatibility ._.

ShGKme · 2025-11-25T18:29:36Z

Rebased onto master
Cleared chore(deps): add [email protected] to be debounce only and in the correct version (2 instead of 3, no Vue version change)
Added fixup with events casing + event handling change
Added fixup with CSS fix

Antreesy

Looks good now!

skjnldsv · 2025-11-26T08:18:53Z

build/frontend/vite.config.mts

 		'settings-admin': resolve(import.meta.dirname, 'apps/user_ldap/src', 'settings-admin.ts'),
 	},
+	user_status: {
+		menu: resolve(import.meta.dirname, 'apps/user_status/src', 'menu.js'),


No typescript ?

Since this is another big chunk of work, I will tackle it later and separately

Yes, the goal of this PR is to migrate the app to Vue 3 with minimal changes. There is much to refactor in this app, but it could be done before and can be done after the Vue 3 migration

ShGKme · 2025-11-26T09:45:48Z

Rebased with fixup squash
Removed @susnux commit — it was conflicting and seemed unneeded in this PR after changes in another PR

susnux · 2025-11-26T09:57:22Z

Removed @susnux commit — it was conflicting and seemed unneeded in this PR after changes in another PR

Yes, thank you :)

Signed-off-by: Grigorii K. Shartsev <[email protected]>

Signed-off-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>

Signed-off-by: Grigorii K. Shartsev <[email protected]>

Antreesy · 2025-11-26T13:12:15Z

/compile

Signed-off-by: nextcloud-command <[email protected]>

susnux · 2025-11-26T13:28:01Z

I am always impressed about that, but I guess its only source maps 😅

ShGKme self-assigned this Nov 20, 2025

ShGKme added 2. developing Work in progress technical debt labels Nov 20, 2025

susnux mentioned this pull request Nov 20, 2025

📦 ❗️Vue 3 Migration - NC33 Roadmap #55428

Open

29 tasks

ShGKme force-pushed the chore/user_status--vue3 branch 2 times, most recently from fa9056c to b837912 Compare November 20, 2025 11:53

susnux reviewed Nov 20, 2025

View reviewed changes

build/frontend/vite.config.mts Outdated Show resolved Hide resolved

ShGKme added this to the Nextcloud 33 milestone Nov 20, 2025

ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 20, 2025

ShGKme changed the base branch from master to fix/build-vite-chunks November 20, 2025 12:30

ShGKme force-pushed the chore/user_status--vue3 branch from b837912 to 5ca53f4 Compare November 20, 2025 12:31

ShGKme requested a review from Antreesy November 20, 2025 12:34

ShGKme force-pushed the fix/build-vite-chunks branch from 06cbc16 to d54009f Compare November 20, 2025 14:09

Base automatically changed from fix/build-vite-chunks to master November 20, 2025 23:17

ShGKme force-pushed the chore/user_status--vue3 branch 2 times, most recently from b78f534 to 2515803 Compare November 21, 2025 16:44

ShGKme marked this pull request as ready for review November 21, 2025 17:44

ShGKme requested review from a team as code owners November 21, 2025 17:44

ShGKme requested review from Altahrim, CarlSchwan, nfebe, sorbaugh and szaimen and removed request for a team November 21, 2025 17:44

szaimen approved these changes Nov 21, 2025

View reviewed changes

susnux approved these changes Nov 25, 2025

View reviewed changes

susnux force-pushed the chore/user_status--vue3 branch from b03e6f9 to f008810 Compare November 25, 2025 11:47

Antreesy reviewed Nov 25, 2025

View reviewed changes

ShGKme force-pushed the chore/user_status--vue3 branch from ae13758 to 8493eeb Compare November 25, 2025 18:29

susnux approved these changes Nov 25, 2025

View reviewed changes

Antreesy approved these changes Nov 25, 2025

View reviewed changes

skjnldsv reviewed Nov 26, 2025

View reviewed changes

Antreesy mentioned this pull request Nov 26, 2025

fix(user_status): adjust online status string #56711

Merged

6 tasks

skjnldsv approved these changes Nov 26, 2025

View reviewed changes

ShGKme force-pushed the chore/user_status--vue3 branch from 8493eeb to ddece38 Compare November 26, 2025 09:44

ShGKme enabled auto-merge November 26, 2025 09:45

ShGKme and others added 4 commits November 26, 2025 14:05

refactor(user_status): prepare for Vue 3 migration

fb44adc

Signed-off-by: Grigorii K. Shartsev <[email protected]>

build(user_status): move from frontend_legacy to frontend

bbd35b2

Signed-off-by: Grigorii K. Shartsev <[email protected]>

chore(deps): add Vuex

b10d5d3

Signed-off-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>

refactor(user_status): migrate to Vue 3

8ca4a7a

Signed-off-by: Grigorii K. Shartsev <[email protected]>

Antreesy force-pushed the chore/user_status--vue3 branch from ddece38 to 8ca4a7a Compare November 26, 2025 13:11

chore(assets): Recompile assets

ea205dd

Signed-off-by: nextcloud-command <[email protected]>

nickvergessen disabled auto-merge November 26, 2025 14:40

nickvergessen merged commit 38792c8 into master Nov 26, 2025
217 of 234 checks passed

nickvergessen deleted the chore/user_status--vue3 branch November 26, 2025 14:40

Uh oh!

refactor(user_status): migrate to Vue 3 #56544

refactor(user_status): migrate to Vue 3 #56544

Uh oh!

Conversation

ShGKme commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

ShGKme commented Nov 21, 2025

Uh oh!

szaimen left a comment

Choose a reason for hiding this comment

Uh oh!

susnux commented Nov 25, 2025

Uh oh!

ShGKme commented Nov 25, 2025

Uh oh!

susnux commented Nov 25, 2025

Uh oh!

susnux commented Nov 25, 2025

Uh oh!

Antreesy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShGKme commented Nov 25, 2025

Uh oh!

ShGKme commented Nov 25, 2025

Uh oh!

Antreesy left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Antreesy Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

ShGKme Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

ShGKme commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

susnux commented Nov 26, 2025

Uh oh!

Antreesy commented Nov 26, 2025

Uh oh!

susnux commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ShGKme commented Nov 20, 2025 •

edited

Loading

ShGKme commented Nov 26, 2025 •

edited

Loading