Skip to content

Fix/fix/theming legacy app config #56626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 2 commits into from
Nov 25, 2025
Merged

Fix/fix/theming legacy app config #56626

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad5f23f
test: add test for theming config casting
icewind1991 Nov 24, 2025
561d3de
fix: fix theming config value casting
icewind1991 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: fix theming config value casting 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Nov 24, 2025
commit 561d3ded2311c6f532f84d20b7bd96ea77dcc325
4 changes: 2 additions & 2 deletions apps/theming/lib/ThemingDefaults.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,12 +431,12 @@ public function increaseCacheBuster(): void {
* @param string $value
*/
public function set($setting, $value): void {
switch ($value) {
switch ($setting) {
case ConfigLexicon::CACHE_BUSTER:
$this->appConfig->setAppValueInt(ConfigLexicon::CACHE_BUSTER, (int)$value);
break;
case ConfigLexicon::USER_THEMING_DISABLED:
$value = $value === 'true' || $value === 'yes' || $value === '1';
$value = in_array($value, ['1', 'true', 'yes', 'on']);
$this->appConfig->setAppValueBool(ConfigLexicon::USER_THEMING_DISABLED, $value);
break;
default:
Expand Down
Loading