fix(sharing): allow federated shares to non-trusted servers #56652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
artonge,
dasisdormax,
skjnldsv,
susnux and
szaimen
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
nfebe
force-pushed
the
fix/federated-share-external-filter
branch
from
aa52ca4 to
8e788be
Compare
Contributor
Author
|
/compile |
szaimen
approved these changes
Nov 25, 2025
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Explanation makes sense but did not test
nfebe
force-pushed
the
fix/federated-share-external-filter
branch
from
6ace53e to
56856a2
Compare
Contributor
Author
|
/compile |
artonge
approved these changes
Dec 2, 2025
nfebe
force-pushed
the
fix/federated-share-external-filter
branch
from
69d1f20 to
f41666f
Compare
Contributor
Author
|
/compile |
1 similar comment
Contributor
Author
|
/compile |
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the trusted server filter was incorrectly applied to both internal and external sharing sections. This prevented users from sharing with federated users on non-trusted servers via the external share UI. The filter now only applies to the internal section, allowing non-trusted federated shares to appear in the external section. Fixes: #56622 Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/federated-share-external-filter
branch
from
f41666f to
0838228
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56652/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 08382282 5de1d46b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56652/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
showFederatedSharesToTrustedServersAsInternalis enabled, the trusted server filter was incorrectly applied to both internal and external sharing sections. This prevented users from sharing with federated users on non-trusted servers via the external share UI.The filter now only applies to the internal section, allowing non-trusted federated shares to appear in the external section.
Fixes: #56622