Skip to content

[stable32] fix(files_sharing): Allow deleting a share of a missing file #56657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 2 commits into from
Nov 27, 2025
Merged

[stable32] fix(files_sharing): Allow deleting a share of a missing file #56657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97ddc1c
fix(files_sharing): Allow deleting a share of a missing file
come-nc Nov 17, 2025
6cdac07
chore: Improve wording in debug log
come-nc Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/files_sharing/lib/Controller/ShareAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,8 @@ public function deleteShare(string $id): DataResponse {
$this->lock($share->getNode());
} catch (LockedException $e) {
throw new OCSNotFoundException($this->l->t('Could not delete share'));
} catch (NotFoundException $e) {
$this->logger->debug('File of to be deleted share was not found, skip locking', ['exception' => $e]);
}

if (!$this->canAccessShare($share)) {
Expand Down
Loading