Skip to content

fix: Fix orphan shares blocking moving other shares #56758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Altahrim merged 2 commits into from
Dec 2, 2025
Merged

fix: Fix orphan shares blocking moving other shares #56758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d64e07
fix: Fix orphan shares blocking moving other shares
come-nc Dec 1, 2025
f453411
fix: Log missing nodes of shares at debug level
come-nc Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Log missing nodes of shares at debug level 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Dec 2, 2025
commit f453411d594a4bb45dd5e51a51d23547acb74331
5 changes: 4 additions & 1 deletion lib/private/Files/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,8 +1885,11 @@ private function targetIsNotShared(string $user, string $targetPath): bool {
foreach ($shares as $share) {
try {
$sharedPath = $share->getNode()->getPath();
} catch (NotFoundException) {
} catch (NotFoundException $e) {
// node is not found, ignoring
$this->logger->debug(
'Could not find the node linked to a share',
['app' => 'files', 'exception' => $e]);
continue;
}
if ($targetPath === $sharedPath || str_starts_with($targetPath, $sharedPath . '/')) {
Expand Down
Loading