-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable30] refactor(workflowengine): Check if class is correct #56845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cb1dcf to
1eb4a8d
Compare
1eb4a8d to
8c3968d
Compare
salmart-dev
reviewed
Dec 8, 2025
8c3968d to
db20a53
Compare
CarlSchwan
approved these changes
Dec 9, 2025
|
|
||
| protected function validateEvents(string $entity, array $events, IOperation $operation) { | ||
| /** @psalm-suppress TaintedCallable newInstance is not called */ | ||
| $reflection = new \ReflectionClass($entity); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion Note
Argument 1 of ReflectionClass::__construct expects class-string|object|trait-string, but parent type string provided
ChristophWurst
approved these changes
Dec 10, 2025
Signed-off-by: Carl Schwan <[email protected]>
db20a53 to
cad12d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56839
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.