fix(files_sharing): make legacy downloadShare endpoint compatible with legacy behavior
#56967
+52
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
yemkareems
and removed request for
a team
…ith legacy behavior This needs to be able to directly download files if specified to only download a single file and not a folder. Also it was possible to either pass a files array json encoded or a single file not encoded at all. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/share-download
branch
from
8a9b944 to
8da8a80
Compare
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
come-nc
approved these changes
Jan 13, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Looks good. Did not test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This needs to be able to directly download files if specified to only download a single file and not a folder.
Also it was possible to either pass a files array json encoded or a single file not encoded at all.
Checklist
3. to review, feature component)stable32)