Improve usability of QR code login #57453
Merged
+853
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested review from
ArtificialOwl,
leftybournes,
nfebe,
sorbaugh,
susnux and
szaimen
and removed request for
a team
Antreesy
approved these changes
Jan 9, 2026
Merged
SystemKeeper
reviewed
Jan 9, 2026
Signed-off-by: Marcel Müller <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>
…an app-password Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
feat/noid/qr-code-in-account-menu
branch
from
4e77da6 to
80f6856
Compare
Signed-off-by: Joas Schilling <[email protected]>
CarlSchwan
approved these changes
Jan 12, 2026
|
|
||
| if ($qrcodeLogin) { | ||
| if ($this->appConfig->getAppValueBool(ConfigLexicon::LOGIN_QRCODE_ONETIME)) { | ||
| $name = 'One time login'; |
Member
Author
There was a problem hiding this comment.
Both should be very temporary as valid devices scanning the code will set a proper name.
But I added it for now
CarlSchwan
reviewed
Jan 12, 2026
Signed-off-by: Joas Schilling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option added directly into the account menu
QR code can be configured to be one-time
Only supported with future mobile clients of Android and iOS. Since old ones break, it's disabled by default for now, but will be enabled by default in a future version.
Also the current settings page does not use this, as it's already showing the app password and we can not change the type afterwards.
Expiration time can be configured with an app config.
Admin setting to disable app password generation
Checklist
3. to review, feature component)stable32)