Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without
strict:true, array_search has an unexpected behavior with string looking like numbers.Example:
I splitted in several commits to ease backporting a bit.
The issue was spotted with user_ldap user cache, but all instances of array_search could be impacted with such a corner case so I added
strict:trueto all array_search calls, apart from object arrays.Checklist
3. to review, feature component)stable32)