still remove the federated share even if we cant notify the remote #5753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @nickvergessen and @rullzer to be potential reviewers. |
schiessle
approved these changes
Jul 18, 2017
Member
schiessle
left a comment
schiessle
left a comment
There was a problem hiding this comment.
looks good. Ideally we would re-try to send the feedback in a background job later again, but for now I think this fix is good
Member
|
Probably something we should backport. |
|
@icewind1991 unfortunately I don't have the possibility to apply a non-release version on our systems |
rullzer
approved these changes
Jul 21, 2017
| try { | ||
| $share = $getShare->fetch(); | ||
| $this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline'); | ||
| } catch (\Exception $e) { |
Member
There was a problem hiding this comment.
\Exception might be a bit generic... but i guess for now OK.
I do agree with @schiessle that we should probabaly inject some background job that will try to notify the remote a few times.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3766
@Esprit-Libre @Gavisann @vojeroen can you verify if this fixes the problem for you