Fix show password button for password change #5895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix the show password button on the personal page * before: if the password change failed the show password icon was not shown again * after: show password icon is visible Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
requested review from
ArtificialOwl,
LukasReschke,
nickvergessen,
oparoz and
rullzer
ArtificialOwl
approved these changes
Jul 26, 2017
Member
|
file is |
Member
Author
|
stable12: #5896 |
Member
Author
Git is smart enough to figure this out in a simple cherry pick 😉 |
Member
|
I really need to learn how to use this tool |
Member
Author
git checkout stable12
git checkout -b backport-NUMBER
git cherry-pick <commit-sha>
git push origin backport-NUMBER |
Member
|
Also very easy using tools like PHPStorm where you can pick, merge, fix, commit |
rullzer
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be backported at least to stable12.