Skip to content

Support subdir in the OCS v2 endpoint #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jul 28, 2016
Merged

Support subdir in the OCS v2 endpoint #609

rullzer merged 1 commit into from
Jul 28, 2016

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jul 27, 2016

Backport of #606

CC: @MorrisJobke @nickvergessen

@rullzer rullzer added the 3. to review Waiting for reviews label Jul 27, 2016
@rullzer rullzer added this to the Nextcloud 10.0 milestone Jul 27, 2016
@mention-bot
Copy link

mention-bot commented Jul 27, 2016

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen to be a potential reviewer

@rullzer rullzer mentioned this pull request Jul 27, 2016
Merged
@nickvergessen
Copy link
Member

nickvergessen commented Jul 27, 2016

👍

1 similar comment
@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 27, 2016

👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 27, 2016
@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 28, 2016

Umm what?

Time: 8.71 minutes, Memory: 236.75Mb

There was 1 failure:

1) Test\Log\OwncloudTest::testMicrosecondsLogTimestamp
Failed asserting that '000000' is not equal to 0.

/drone/src/github.com/nextcloud/server/tests/lib/Log/OwncloudTest.php:75

--

@rullzer
Copy link
Member Author

rullzer commented Jul 28, 2016

Let me rebase and push...

@rullzer
Support subdir in the OCS v2 endpoint
6990a4e 
We should check against the ending substring since people could
run their nextcloud in a subfolder.

* Added test
@rullzer rullzer merged commit e184e4a into stable10 Jul 28, 2016
@rullzer rullzer deleted the stable10_606 branch July 28, 2016 12:23
@nalt nalt mentioned this pull request Feb 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @mention-bot @nickvergessen @MorrisJobke