Skip to content

Conversation

@icewind1991
Copy link
Member

This makes it cheap to not only get all users with access to a file but also get the path to the file for those users.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 22, 2017
@icewind1991 icewind1991 added this to the Nextcloud 13 milestone Aug 22, 2017
@icewind1991 icewind1991 force-pushed the cached-mount-info-filepath branch from 4dbaef2 to 05e1004 Compare August 22, 2017 15:44
@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #6220 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##             master    #6220      +/-   ##
============================================
+ Coverage     52.82%   52.83%   +<.01%     
- Complexity    22802    22806       +4     
============================================
  Files          1442     1443       +1     
  Lines         88562    88581      +19     
  Branches       1349     1349              
============================================
+ Hits          46787    46805      +18     
- Misses        41775    41776       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Config/UserMountCache.php 92.89% <100%> (+0.39%) 40 <0> (ø) ⬇️
lib/private/Files/Config/CachedMountFileInfo.php 90% <90%> (ø) 4 <4> (?)
lib/private/Server.php 83.47% <0%> (-0.13%) 124% <0%> (ø)
lib/private/Security/CertificateManager.php 92.07% <0%> (+0.99%) 39% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke MorrisJobke force-pushed the cached-mount-info-filepath branch from 97d1ffe to 3f0cb13 Compare October 27, 2017 12:36
@MorrisJobke
Copy link
Member

Rebased to trigger CI again.

@MorrisJobke
Copy link
Member

@rullzer @nickvergessen Please have a look at this.

@LukasReschke LukasReschke merged commit 989a8a3 into master Nov 8, 2017
@LukasReschke LukasReschke deleted the cached-mount-info-filepath branch November 8, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants