up the minimum size of the public share video a bit, use 16/9 ratio

[jancborchardt]

fix #603 – ended up using half the size of Youtube’s 854*480px since that is a bit too big.

Please review @icewind1991 @oparoz @schiessle

[mention-bot]

@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @MorrisJobke and @oparoz to be potential reviewers

[oparoz]

@jancborchardt Does it work nicely on mobile?

[jancborchardt]

@oparoz yep it does – you can simply make your window smaller to test. :) That’s also why I chose the smaller 427 * 240px instead of the full 854 * 480px. It will always use maximally 100% of the viewport width.

[icewind1991]

Shouldn't this be min-width/height?

[jancborchardt]

@icewind1991 no, because then on mobile when the screen is smaller than this it will cause scrolling.

[jancborchardt]

Sooo – @oparoz @icewind1991 can you actually test this and give it thumbs up? ;D

[icewind1991]

@icewind1991 no, because then on mobile when the screen is smaller than this it will cause scrolling.

Also set max-width 100%

Imo this is to small for non mobile screens

[MorrisJobke]

Imo this is to small for non mobile screens

Indeed:

Doubled size:

[jancborchardt]

Seems there was some inline stuff setting other max-widths which messed it up. Needed to add !important to fix it. Please review again :)

[MorrisJobke]

A lot better now 👍 Works

[icewind1991]

👍

[MorrisJobke]

@karlitschek Port to stable10?

[jancborchardt]

I’d say it’s a nice detail/fix for sharing and a backport would be cool.

[karlitschek]

nice. please backport 👍

[jancborchardt]

Backport at #668