Skip to content

Add confirmation button to share input #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 17 commits into from
Mar 21, 2018
Merged

Add confirmation button to share input #7196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ce7775a
Replace information icon with confirmation button in share input
jancborchardt Nov 16, 2017
6fef01c
Adjust search term to test
danxuliu Mar 16, 2018
375eab9
Add tests for emails and circles already shared with
danxuliu Mar 16, 2018
8af9c55
Add tests for exact search results already shared with
danxuliu Mar 16, 2018
3980364
Add autocompletion tests for each type of share
danxuliu Mar 16, 2018
d606219
Extract code to get suggestions to its own method
danxuliu Mar 16, 2018
fcef15a
Move stub setup outside the test method
danxuliu Mar 19, 2018
ed1452d
Use "showTemporary" instead of explicitly hiding the notification
danxuliu Mar 19, 2018
1c44051
Show an error when getting the suggestions succeeds with failure content
danxuliu Mar 19, 2018
89b0e34
Extract code to filter suggestions to its own function
danxuliu Mar 19, 2018
5e2a8cc
Return also exact matches besides all suggestions
danxuliu Mar 19, 2018
9371b61
Add a share when clicking on the confirm button
danxuliu Mar 19, 2018
10a4f8e
Confirm a share also by pressing enter on the input field
danxuliu Mar 20, 2018
6eb5cc5
Reuse last suggestions if the same parameters are used
danxuliu Mar 20, 2018
9a0fbe3
Discard cached suggestions when adding a share
danxuliu Mar 21, 2018
a2c52cd
Extract code to restore the UI after confirming a share
danxuliu Mar 20, 2018
203bf51
Keep showing the working icon while there are pending operations
danxuliu Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reuse last suggestions if the same parameters are used 
When a share is confirmed the suggestions are got to check if there is
an exact match. Usually the suggestions were already got with the same
parameters in order to fill the autocomplete dropdown, so to avoid a
superfluous request now the last suggestions are reused when got again,
although only if the same parameters as the last time are used.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Mar 21, 2018
commit 6eb5cc54120168351286572b18bd1e07dc3bbc5c
19 changes: 18 additions & 1 deletion core/js/sharedialogview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@
/** @type {object} **/
shareeListView: undefined,

/** @type {object} **/
_lastSuggestions: undefined,

events: {
'focus .shareWithField': 'onShareWithFieldFocus',
'input .shareWithField': 'onShareWithFieldChanged',
Expand Down Expand Up @@ -136,6 +139,13 @@
},

_getSuggestions: function(searchTerm, perPage, model) {
if (this._lastSuggestions &&
this._lastSuggestions.searchTerm === searchTerm &&
this._lastSuggestions.perPage === perPage &&
this._lastSuggestions.model === model) {
return this._lastSuggestions.promise;
}

var deferred = $.Deferred();

$.get(
Expand Down Expand Up @@ -289,7 +299,14 @@
deferred.reject();
});

return deferred.promise();
this._lastSuggestions = {
searchTerm: searchTerm,
perPage: perPage,
model: model,
promise: deferred.promise()
};

return this._lastSuggestions.promise;
},

autocompleteHandler: function (search, response) {
Expand Down
174 changes: 174 additions & 0 deletions core/js/tests/specs/sharedialogviewSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,180 @@ describe('OC.Share.ShareDialogView', function() {
}])).toEqual(true);
expect(failStub.called).toEqual(false);
});

it('does not send a request to the server again for the same parameters', function() {
var doneStub = sinon.stub();
var failStub = sinon.stub();

dialog._getSuggestions('bob', 42, shareModel).done(doneStub).fail(failStub);

var jsonData = JSON.stringify({
'ocs': {
'meta': {
'status': 'success',
'statuscode': 100,
'message': null
},
'data': {
'exact': {
'users': [
{
'label': 'bob',
'value': {
'shareType': OC.Share.SHARE_TYPE_USER,
'shareWith': 'user1'
}
}
],
'groups': [],
'remotes': []
},
'users': [],
'groups': [],
'remotes': [],
'lookup': []
}
}
});

expect(doneStub.called).toEqual(false);
expect(failStub.called).toEqual(false);

fakeServer.requests[0].respond(
200,
{'Content-Type': 'application/json'},
jsonData
);

expect(doneStub.calledOnce).toEqual(true);
expect(doneStub.calledWithExactly([{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}], [{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}])).toEqual(true);
expect(failStub.called).toEqual(false);

var done2Stub = sinon.stub();
var fail2Stub = sinon.stub();

dialog._getSuggestions('bob', 42, shareModel).done(done2Stub).fail(fail2Stub);

expect(doneStub.calledOnce).toEqual(true);
expect(failStub.called).toEqual(false);

expect(done2Stub.calledOnce).toEqual(true);
expect(done2Stub.calledWithExactly([{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}], [{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}])).toEqual(true);
expect(fail2Stub.called).toEqual(false);
});

it('sends a request to the server again for the same parameters if the calls are not consecutive', function() {
var doneStub = sinon.stub();
var failStub = sinon.stub();

dialog._getSuggestions('bob', 42, shareModel).done(doneStub).fail(failStub);

var jsonData = JSON.stringify({
'ocs': {
'meta': {
'status': 'success',
'statuscode': 100,
'message': null
},
'data': {
'exact': {
'users': [
{
'label': 'bob',
'value': {
'shareType': OC.Share.SHARE_TYPE_USER,
'shareWith': 'user1'
}
}
],
'groups': [],
'remotes': []
},
'users': [],
'groups': [],
'remotes': [],
'lookup': []
}
}
});

expect(doneStub.called).toEqual(false);
expect(failStub.called).toEqual(false);

fakeServer.requests[0].respond(
200,
{'Content-Type': 'application/json'},
jsonData
);

expect(doneStub.calledOnce).toEqual(true);
expect(doneStub.calledWithExactly([{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}], [{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}])).toEqual(true);
expect(failStub.called).toEqual(false);

var done2Stub = sinon.stub();
var fail2Stub = sinon.stub();

dialog._getSuggestions('bob', 108, shareModel).done(done2Stub).fail(fail2Stub);

expect(done2Stub.called).toEqual(false);
expect(fail2Stub.called).toEqual(false);

fakeServer.requests[1].respond(
200,
{'Content-Type': 'application/json'},
jsonData
);

expect(done2Stub.calledOnce).toEqual(true);
expect(fail2Stub.called).toEqual(false);

var done3Stub = sinon.stub();
var fail3Stub = sinon.stub();

dialog._getSuggestions('bob', 42, shareModel).done(done3Stub).fail(fail3Stub);

expect(done3Stub.called).toEqual(false);
expect(fail3Stub.called).toEqual(false);

fakeServer.requests[2].respond(
200,
{'Content-Type': 'application/json'},
jsonData
);

expect(doneStub.calledOnce).toEqual(true);
expect(failStub.called).toEqual(false);
expect(done2Stub.calledOnce).toEqual(true);
expect(fail2Stub.called).toEqual(false);

expect(done3Stub.calledOnce).toEqual(true);
expect(done3Stub.calledWithExactly([{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}], [{
'label': 'bob',
'value': {'shareType': OC.Share.SHARE_TYPE_USER, 'shareWith': 'user1'}
}])).toEqual(true);
expect(fail3Stub.called).toEqual(false);
});
});
describe('autocompletion of users', function() {
var showTemporaryNotificationStub;
Expand Down