Skip to content

Use apps versions to generate suffix when possible #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 4 commits into from
Dec 11, 2017
Merged

Use apps versions to generate suffix when possible #7244

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
820e7b5
Use apps versions to generate suffix when possible
skjnldsv Nov 22, 2017
f018bfc
Fixed md5 generation and added fallback for scss requests
skjnldsv Dec 5, 2017
1ac3126
Fixed phpdoc and function type
skjnldsv Dec 8, 2017
52e7d05
Fix syntax error
MorrisJobke Dec 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix syntax error 
Signed-off-by: Morris Jobke <[email protected]>
  • Loading branch information
@MorrisJobke
MorrisJobke committed Dec 11, 2017
commit 52e7d05163f21993bdcef25c26ebfa4487e55305
2 changes: 1 addition & 1 deletion lib/private/TemplateLayout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ public function getAppNamefromPath($path) {
}
return end($pathParts);
}
return false
return false;

Copy link
Member

@rullzer rullzer Dec 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't lie in your phpdoc 😉 If you say you returning a string do so :P

}

Expand Down