Skip to content

Increment the versions and adjust the capitilization #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 4 commits into from
Aug 8, 2016
Merged

Increment the versions and adjust the capitilization #739

MorrisJobke merged 4 commits into from
Aug 8, 2016

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 4, 2016

No description provided.

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Aug 4, 2016
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Aug 4, 2016
@mention-bot
Copy link

mention-bot commented Aug 4, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @schiessle, @MTGap, @DeepDiver1975 and @Xenopathic to be potential reviewers

blizzz
blizzz reviewed Aug 5, 2016
View reviewed changes
apps/files_sharing/appinfo/info.xml Outdated
<info>
<id>files_sharing</id>
<name>Share Files</name>
<name>Files sharing</name>
Copy link
Member

@blizzz blizzz Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using singular seems more usual: https://en.wikipedia.org/wiki/File_sharing

Copy link
Member Author

@nickvergessen nickvergessen Aug 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 5, 2016

Beside the comment of Arthur this looks good 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 5, 2016

👍

@rullzer rullzer force-pushed the increment-versions-master branch from 01246da to e7b5155 Compare August 8, 2016 14:47
@rullzer
Copy link
Member

rullzer commented Aug 8, 2016

I fixed the intergration tests (admin audit is no longer enabled by default, trivial patch).
👍

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 8, 2016
@MorrisJobke MorrisJobke merged commit 97c8232 into master Aug 8, 2016
@MorrisJobke MorrisJobke deleted the increment-versions-master branch August 8, 2016 16:05
@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 8, 2016

@rullzer Could I ask you to create the backport PR? Thanks :)

@rullzer
Copy link
Member

rullzer commented Aug 8, 2016

@MorrisJobke already done by @nickvergessen #738

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 8, 2016

@MorrisJobke already done by @nickvergessen #738

@rullzer When this is created we could also drop the backport-request label. Makes it then easier to find the not yet backported PRs ;)

GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
@MorrisJobke
Merge pull request nextcloud#739 from nextcloud/increment-versions-ma…
a9b64b8 
…ster

Increment the versions and adjust the capitilization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @mention-bot @MorrisJobke @rullzer @blizzz