Skip to content

Keep all shipped apps enabled because they should be okay #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jan 16, 2018
Merged

Keep all shipped apps enabled because they should be okay #7879

MorrisJobke merged 1 commit into from
Jan 16, 2018

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 16, 2018

Fix #7865

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Jan 16, 2018
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jan 16, 2018
rullzer
rullzer approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At leasts fixes most of the effect from the issue

blizzz
blizzz approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a start :)

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2018
@codecov
Copy link

codecov bot commented Jan 16, 2018 •
edited
Loading

Codecov Report

Merging #7879 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #7879      +/-   ##
============================================
- Coverage     51.24%   51.24%   -0.01%     
  Complexity    24931    24931              
============================================
  Files          1604     1604              
  Lines         94970    94969       -1     
  Branches       1376     1376              
============================================
- Hits          48670    48668       -2     
- Misses        46300    46301       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 54.17% <0%> (+0.1%) 222 <0> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/public/User.php 50% <0%> (ø) 10% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit 9a99fc0 into master Jan 16, 2018
@MorrisJobke MorrisJobke deleted the bugfix/7865/dont-disable-shipped-apps-on-errors branch January 16, 2018 12:36
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 16, 2018

@nickvergessen Could you open the backport to stable13? Thanks

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 16, 2018

And stable12

This was referenced Jan 16, 2018
Merged
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 16, 2018

Done ^

@MorrisJobke MorrisJobke mentioned this pull request Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @MorrisJobke @rullzer @blizzz