Skip to content

Fix the type hints of migrations and correctly inject the wrapped sch… #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jan 17, 2018
Merged

Fix the type hints of migrations and correctly inject the wrapped sch… #7909

MorrisJobke merged 1 commit into from
Jan 17, 2018

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 17, 2018 •
edited by MorrisJobke
Loading

@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jan 17, 2018
This was referenced Jan 17, 2018
Merged
Merged
Closed
@codecov
Copy link

codecov bot commented Jan 17, 2018 •
edited
Loading

Codecov Report

Merging #7909 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #7909      +/-   ##
============================================
- Coverage     51.23%   51.15%   -0.09%     
- Complexity    24920    24983      +63     
============================================
  Files          1604     1604              
  Lines         94968    95124     +156     
  Branches       1376     1376              
============================================
- Hits          48658    48657       -1     
- Misses        46310    46467     +157
Impacted Files Coverage Δ Complexity Δ
core/Command/Db/Migrations/GenerateCommand.php 0% <ø> (ø) 13 <0> (ø) ⬇️
...av/lib/Migration/Version1004Date20170825134824.php 0% <ø> (ø) 12 <0> (ø) ⬇️
...es/lib/Migration/Version1002Date20170607113030.php 0% <ø> (ø) 6 <0> (ø) ⬇️
...av/lib/Migration/Version1004Date20170926103422.php 0% <ø> (ø) 1 <0> (ø) ⬇️
core/Migrations/Version13000Date20170718121200.php 0% <ø> (ø) 30 <0> (ø) ⬇️
core/Migrations/Version13000Date20170814074715.php 0% <ø> (ø) 4 <0> (ø) ⬇️
lib/public/Migration/BigIntMigration.php 0% <ø> (ø) 4 <0> (ø) ⬇️
...es/lib/Migration/Version1002Date20170607104347.php 0% <ø> (ø) 2 <0> (ø) ⬇️
...es/lib/Migration/Version1002Date20170926101419.php 0% <ø> (ø) 1 <0> (ø) ⬇️
core/Migrations/Version13000Date20170705121758.php 0% <ø> (ø) 3 <0> (ø) ⬇️
... and 12 more

MorrisJobke
MorrisJobke approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 24c58d3 into master Jan 17, 2018
@MorrisJobke MorrisJobke deleted the fix-migration-type-hints branch January 17, 2018 12:48
@nickvergessen nickvergessen mentioned this pull request Jan 17, 2018
Merged
splitt3r added a commit to nextcloud/polls that referenced this pull request Jan 17, 2018
@splitt3r
Fixed Travis CI + nextcloud/server#7909
e6ca2e5
splitt3r added a commit to nextcloud/polls that referenced this pull request Jan 17, 2018
@splitt3r
Merge pull request #285 from nextcloud/fix-migration-type-hints
1b5b99b 
Fixed Travis CI + nextcloud/server#7909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @rullzer @MorrisJobke